-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20 px statusbar height in modals on iPad #1605
Comments
Hey @ohh2ahh, are you using the latest beta? I'm not able to reproduce this on a nexus tablet looking at Ionic's modal demo: http://codepen.io/perrygovier/pen/uFjIm |
Hi @perrygovier and thanks for taking a look. It seems that the gap for the statusbar is only added on iOS and it's only an issue on iPad (landscape and portrait).
Steps to reproduce it:
Here's a screenshot: |
Thanks for the screenshot. Fixing. |
Note, given that it's on an iPad aspect ratio, I wasn't sure how we could create a test for this in our current e2e setup. It is confirmed in this codepen though. http://codepen.io/perrygovier/pen/KqriH |
Is this fix part of "release: v1.0.0-beta.9 "gadolinium-gator" ? |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
I noticed that Ionic adds a 20 px height to the modal's header-bar. It's perfectly fine on an iPhone. But on the iPad there's no need for this gap because the modal isn't fullscreen.
The text was updated successfully, but these errors were encountered: