Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20 px statusbar height in modals on iPad #1605

Closed
ohh2ahh opened this issue Jun 11, 2014 · 6 comments
Closed

20 px statusbar height in modals on iPad #1605

ohh2ahh opened this issue Jun 11, 2014 · 6 comments
Assignees

Comments

@ohh2ahh
Copy link

ohh2ahh commented Jun 11, 2014

I noticed that Ionic adds a 20 px height to the modal's header-bar. It's perfectly fine on an iPhone. But on the iPad there's no need for this gap because the modal isn't fullscreen.

@perrygovier
Copy link
Contributor

Hey @ohh2ahh, are you using the latest beta? I'm not able to reproduce this on a nexus tablet looking at Ionic's modal demo: http://codepen.io/perrygovier/pen/uFjIm

@perrygovier perrygovier self-assigned this Jun 11, 2014
@ohh2ahh
Copy link
Author

ohh2ahh commented Jun 11, 2014

Hi @perrygovier and thanks for taking a look.

It seems that the gap for the statusbar is only added on iOS and it's only an issue on iPad (landscape and portrait).

  • Ionic v1.0.0-beta.6
  • Cordova 3.5.0-0.2.4
  • iOS Simulator with iOS 7.1.1

Steps to reproduce it:

  1. Created a new project with $ ionic start myApp blank
  2. Add modal (I did it like this: http://codepen.io/anon/pen/Adogq)
  3. Run app on an iPad (Xcode Simulator or real iPad)

Here's a screenshot:

issue_1605

@ajoslin
Copy link
Contributor

ajoslin commented Jun 12, 2014

Thanks for the screenshot. Fixing.

@perrygovier
Copy link
Contributor

Note, given that it's on an iPad aspect ratio, I wasn't sure how we could create a test for this in our current e2e setup. It is confirmed in this codepen though. http://codepen.io/perrygovier/pen/KqriH

@ferryfax
Copy link

Is this fix part of "release: v1.0.0-beta.9 "gadolinium-gator" ?

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants