Collection Repeat With Search Input #2523
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my post on the forum which outlines an issue with re-rendering a collection-repeat list following a filter being applied through a search input. If I first scroll down the list and then enter the search term, the new filtered list is not scrolled to the top. You can reproduce in this codepen. The items are all there and present but the scroll view doesn't seem to resize. If you delete the search input text and re-enter again, it all works fine as the scroll has been reset to the top of the list.
On a project I was working on, I implemented a temporary fix by adding
scrollView.scrollTo(0,0, false, null, true);
to the end of therenderer(value)
function within the collectionRepeat directive in ionic.bundle.js.I'm not sure if this is the best way to resolve this issue but if someone wants to advise/confirm the best solution, I will happily create a PR with a fix.