fix(scroll): ignore events during slide-box slide

[stephenplusplus]

I don't expect this PR to be merged. @mhartington mentioned there was a refactoring of the slidebox going on, so this probably isn't aligned with those efforts. Nonetheless, I thought it might be helpful for others affected by the "scroll leak" introduced in beta 14.

The details of the bug can be found in various issues on the forum:

• http://forum.ionicframework.com/t/beta14-slide-box-vertical-scroll-behaviour
• http://forum.ionicframework.com/t/beta-14-slide-box-limit-scroll-whilst-sliding
• http://forum.ionicframework.com/t/ion-content-scroll-locking-doesnt-work

The implementation followed the lead of ionic.scroll.isScrolling by introducing ionic.slide.isSliding so that the two may communicate as necessary. isSliding turns on during a slide view's touchmove and off in touchend. When isSliding is true, it interrupts any scroll view scrolling events.

Tests didn't break, but I also didn't add any tests (back to not thinking this would be merged). If I was mistaken, or this is terrible for other reasons I cannot see, please let me know!

Thanks, and Happy Holidays ionic team!

[ChristianKohler]

Hi Stephen

Works very well. I tested it on a iPhone 5 and a Nexus 7. Would be great to see feature in the next version of ionic.

Thanks and happy new year!

[bferreirainfo]

@mhartington said:
Hey guys, this is something known to the team. We have a whole separate slide-box branch that we're working on.

guess better waiting.

[travisdahl]

Any progress on this?

[vlad-bezden]

Hi guys, do you have information if this issue is going to be fixed in release 1.0? I downloaded rc 1 and looks like this issue is still there. Thanks.

[mhartington]

It should be fixed in the nightly builds.

Mike Hartington

On Mar 14, 2015, at 7:47 PM, Vlad Bezden [email protected] wrote:

Hi guys, do you have information if this issue is going to be fixed in release 1.0? I downloaded rc 1 and looks like this issue is still there. Thanks.

—
Reply to this email directly or view it on GitHub.

[travisdahl]

@mhartington I thought is was fixed in the nightly but I was mistaken. Still an issue. In mid slide if you hold your finger on the screen you can still move the slide both x and y. All over the place. When you are scrolling vertically on a slide it locks it from sliding the slidebox horizontally but not vice versa

[Fayozjon]

Travis

http://www.baltdivision.ru/brejk

15.03.2015, 06:42, "Travis Dahl" [email protected]: I thought is was fixed but I was mistaken. Still an issue. In mid slide if you hold your finger on the screen you can still move the slide both x and y. All over the place. When you are scrolling vertically on a slide it locks it from sliding the slidebox but not vice versa

—Reply to this email directly or .

[szuzul]

+1 to finish this one.

[dr75]

Another +1 to finish this

[bferreirainfo]

+1 my app will be in production soon, and this is a very ugly problem.

[vlad-bezden]

I just checked v1 rc2 and this issue still exists there. Could you please update on when it's going to be fixed? Thank you.

[antonshevchenko]

+1

[stephenplusplus]

Thanks!

[travisdahl]

Thanks! Just tested. Looks great!

[glemiere]

What about ionic 3 ?

[cristianduro]

Any progress for Ionic 3??? I mean, is working fine in Chrome, etc, but definitely not on iOS. Vertical scroll is still present on iOS while dragging any slide. :(

[cnavarroestrella]

Is there no solution for Ionic 3? It feels terrible in iOS.