Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Swiping in menu closes the menu #5511

Closed
lordgreg opened this issue Feb 18, 2016 · 2 comments
Closed

bug: Swiping in menu closes the menu #5511

lordgreg opened this issue Feb 18, 2016 · 2 comments
Assignees
@manucorporat
Milestone
2.0.0-beta.9

Comments

@lordgreg
Copy link

Type: bug

Ionic Version: 2.x

Platform: all

Steps to reproduce:

  1. Create simple app with menu (on the left)
  2. Open menu
  3. ON MENU swipe from left to right. It will close the menu.
  4. ON MENU swipe diagonally from left to right. It will close the menu.
  5. Fin.
@jgw96
Copy link
Contributor

jgw96 commented Feb 21, 2016

Did some research on this issue, it seems to be caused by the SlideEdgeGesture not actually detecting the direction of the slide, therefore closing the menu even if the slide gesture is not going in the "close" direction.

@brandyscarney brandyscarney added this to the 2.0.0-beta.7 milestone Mar 1, 2016
@jgw96 jgw96 modified the milestones: 2.0.0-beta.10, 2.0.0-beta.9 Jun 8, 2016
@manucorporat
Copy link
Contributor

@lordgreg I am working right now in a PR to fix this, and it will include several additional improvements as well.

manucorporat added a commit to manucorporat/ionic that referenced this issue Jun 9, 2016
@manucorporat
fix(menu): swiping menu distinguishes between opening and closing dir…
f9a5a2d 
…ection

closes ionic-team#5511
@manucorporat manucorporat mentioned this issue Jun 9, 2016
Merged
adamdbradley pushed a commit that referenced this issue Jun 9, 2016
@manucorporat @adamdbradley
fix(menu): swiping menu distinguishes between opening and closing dir…
29791f8 
…ection

Closes #5511
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@manucorporat manucorporat

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.9
Development

No branches or pull requests
6 participants
@manucorporat @adamdbradley @lordgreg @brandyscarney @Ionitron @jgw96