Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue(tabs): Spacing problem with 5 tabs on iOS #6056

Closed
dylanvdmerwe opened this issue Apr 6, 2016 · 7 comments
Closed

Issue(tabs): Spacing problem with 5 tabs on iOS #6056

dylanvdmerwe opened this issue Apr 6, 2016 · 7 comments
Assignees
Labels
help wanted a good issue for the community
Milestone

Comments

@dylanvdmerwe
Copy link
Contributor

Short description of the problem:

When adding more than 4 tabs on iOS the spacing of tabs goes over the screen.

What behavior are you expecting?

On iOS, the maximum number of tabs that can be added are 5. At the very least, 5 tabs should fix on an iOS device.

iOS (Ionic 2 with 5 tabs)
capture

iOS (Native with 5 tabs)
capture3

Android
capture2

Which Ionic Version? 2.x

Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.1.1
Ionic Framework Version: 2.0.0-beta.3
Ionic CLI Version: 2.0.0-beta.24
Ionic App Lib Version: 2.0.0-beta.14
OS:
Node Version: v5.7.0

@adamdbradley adamdbradley added this to the 2.0.0-beta.6 milestone Apr 6, 2016
@adamdbradley adamdbradley added the help wanted a good issue for the community label Apr 6, 2016
@jgw96 jgw96 added tabs labels Apr 6, 2016
@ben-kn-app
Copy link

Just adding my 2 cents. Was able to replicate this problem with 5 tabs on device iPhone 5s and also on iPhone 5s simulator. Seems the .tab-button style (in app.ios.css) has a max-width: 240px; causing this behavior. Removing this max-width for iPhone 5s seems to solve the problem. The max-width was added probably with a reason (what is the reason?) so this is not a fix. Should be investigated further, but could point you in the (hopefully) right direction.

@dylanvdmerwe
Copy link
Contributor Author

@brandyscarney does that sound like a reasonable fix?

@brandyscarney
Copy link
Member

@dylanvdmerwe I'm not seeing the problem resolved by removing the max-width, only by removing the min-width: 80px. You should be able to set:

$tab-button-ios-min-width: auto;

In your theme/app.ios.scss file as a temporary work around until I can look into this more and make sure it doesn't break anything by removing it. 😄

@brandyscarney
Copy link
Member

Fixed for beta.7. I didn't see any negative results of removing this but let me know if anyone does. Thanks for the issue!

@mypark
Copy link

mypark commented May 8, 2016

might want to adjust the tab padding as well since it ellipses the tab titles when it gets that small when it doesn't have to.

@brandyscarney
Copy link
Member

@mypark could you create a new issue for this please and tag me in it? 😄

@mypark
Copy link

mypark commented May 27, 2016

ok, created issue #6679

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted a good issue for the community
Projects
None yet
Development

No branches or pull requests

7 participants