Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item-sliding: icon not on top by default #6662

Closed
icarus31 opened this issue May 25, 2016 · 4 comments
Closed

Item-sliding: icon not on top by default #6662

icarus31 opened this issue May 25, 2016 · 4 comments
Assignees
Milestone

Comments

@icarus31
Copy link

Comment from @brandyshea

Actually, the icons should be on the top by default. This is definitely a bug caused by the pipe. Adding it is causing the wrong classes to be added to the button, so it doesn't think the text is there

@jgw96 jgw96 added the v2 label May 27, 2016
@brandyscarney
Copy link
Member

Sample code to reproduce the problem:

  <ion-item-options>
    <button danger (click)="delete(slidingItem)">
      <ion-icon name="trash"></ion-icon>
      {{ 'DELETE' | translate }}
    </button>

    <button danger (click)="stop(slidingItem)">
      <ion-icon name="hand"></ion-icon>
      {{ 'STOP' | translate }}
    </button>    
  </ion-item-options>

@brandyscarney brandyscarney added this to the 2.0.0-beta.9 milestone May 31, 2016
@brandyscarney brandyscarney self-assigned this May 31, 2016
@carlosfavero
Copy link

carlosfavero commented Jun 5, 2016

work for me.. add

        <ion-item-options>
          <button secondary (click)="openItem(item, slidingItem)">
            <ion-icon name="cash"></ion-icon><strong>Cash</strong>
          </button>
          <button danger (click)="delete(item, slidingItem)">
            <ion-icon name="trash"></ion-icon>Delete
          </button>
       </ion-item-options>

@brandyscarney
Copy link
Member

This actually happens with any interpolated text, not only with a pipe. The following will reproduce it:

<ion-item-sliding #item>
  <ion-item>
    One Line, Dynamic option text
  </ion-item>
  <ion-item-options>
    <button primary>
      <ion-icon name="more"></ion-icon>
      {{ moreText }}
    </button>
    <button secondary (click)="archive(item)">
      <ion-icon name="archive"></ion-icon>
      {{ archiveText }}
    </button>
  </ion-item-options>
</ion-item-sliding>

@brandyscarney
Copy link
Member

Thanks for the issue! This will be fixed with the beta 9 release. :)

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants