Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Spinner color #7401

Closed
MatanYadaev opened this issue Jul 22, 2016 · 4 comments
Closed

feat: Spinner color #7401

MatanYadaev opened this issue Jul 22, 2016 · 4 comments
Assignees
@brandyscarney
Milestone
2.0.0-beta.12

Comments

@MatanYadaev
Copy link

MatanYadaev commented Jul 22, 2016 •
edited
Loading

Type: feat

Ionic Version: 2.x

Platform: all

Ion-spinner is only black color, and to change it you need to use css.
Please make it possible:
<ion-spinner primary></ion-spinner>
@jgw96 jgw96 added enhancement and removed feature labels Jul 22, 2016
@brandyscarney
Copy link
Member

Related to #7087

@brandyscarney brandyscarney self-assigned this Jul 22, 2016
@brandyscarney brandyscarney added this to the 2.0.0-beta.12 milestone Aug 19, 2016
brandyscarney added a commit that referenced this issue Aug 19, 2016
@brandyscarney
fix(spinner): add color input property to spinner, fix class clobbering
048b086 
fixes #7087 fixes #7401
@mlynch
Copy link
Contributor

mlynch commented Aug 23, 2016

@brandyscarney did your commit above fix this?

@brandyscarney
Copy link
Member

@mlynch Yes, it will be fixed once my branch is merged.

@brandyscarney
Copy link
Member

Thanks for the issue! This will be fixed in the beta 12 release. You will be able to pass a color via the color input. See this file for some examples: https://github.com/driftyco/ionic/blob/master/src/components/spinner/test/colors/main.html

t1bb4r pushed a commit to t1bb4r/ionic that referenced this issue Sep 8, 2016
@brandyscarney @t1bb4r
fix(spinner): add color input property to spinner, fix class clobbering
30c29ed 
fixes ionic-team#7087 fixes ionic-team#7401
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.12
Development

No branches or pull requests
5 participants
@mlynch @brandyscarney @Ionitron @jgw96 @MatanYadaev