Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: update material design tabs to match bottom navigation #7455

Closed
5 tasks done
brandyscarney opened this issue Jul 29, 2016 · 1 comment
Closed
5 tasks done

Tabs: update material design tabs to match bottom navigation #7455

brandyscarney opened this issue Jul 29, 2016 · 1 comment
Assignees
@adamdbradley @brandyscarney
Milestone
2.0.0-beta.11

Comments

@brandyscarney
Copy link
Member

brandyscarney commented Jul 29, 2016 •
edited
Loading

From our framework meeting notes:

Tabs

  • Material Design tabs will default to the bottom
  • Update styles to the MD spec bottom navigation: https://material.google.com/components/bottom-navigation.html
  • Use config to change the tabs to the “old way” or the top
  • Improve Sass variables for tabs to be more consistent
  • Open a separate issue to update the theming docs #733
@brandyscarney brandyscarney added this to the 2.0.0-beta.11 milestone Jul 29, 2016
brandyscarney added a commit that referenced this issue Jul 29, 2016
@brandyscarney
refactor(tabs): change the material design tabs to act as bottom navi…
4dc53a2 
…gation

Update tabs to reflect the material design bottom navigation spec:
https://material.google.com/components/bottom-navigation.html#bottom-nav
igation-usage

BREAKING CHANGES:

Material design mode defaults have changed to the following:

```
tabsHighlight: false,
tabsPlacement: 'bottom',
tabsHideOnSubPages: false
```

`tabsHighlight` can now be passed as an attribute on the `ion-tabs`
element, this allows for tabs to be added in multiple places inside of
an app and enable the highlight on some of them.

references #7455
brandyscarney added a commit that referenced this issue Jul 29, 2016
@brandyscarney
refactor(tabs): update Sass variable naming to be more consistent
af01841 
Added comments on each Sass variable.

references #5651 references #7455
@brandyscarney
Copy link
Member Author

Need to link to this diff in breaking changes: af01841

brandyscarney added a commit that referenced this issue Aug 1, 2016
@brandyscarney
feat(tabs): add the transition for material design tabs
eea7e6b 
refactored the sass naming to use `text-capitalization` instead of
`text-transform` since it now has an actual `transform` property and I
think this will be less confusing than having a `text-text-transform`
and a `text-transform`.

references #7455
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adamdbradley adamdbradley

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.11
Development

No branches or pull requests
3 participants
@adamdbradley @brandyscarney @Ionitron