-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ionic2: ion-input Issue with label not floating up when type is a number and value is 0 #8019
Comments
Thanks for the plunker! Note to self/team: the |
Not initialized to zero but set to zero dynamically |
Just merge the PR |
Hello @keithdmoore thanks for posting a PR 😄 . There is currently a code freeze on master because of all the internal changes going on with the completely new AOT compile, tree shaking, and minifying build process we are working on. Because of this it may be a little while before your PR is merged, but be assured that we will be looking at it. |
Ok. Thanks for letting me know. Cheers! |
@keithdmoore thanks a lot for the PR. But it could not longer be merged without conflict so I used your fix. |
@manucorporat No problem. Thanks for working this one. Glad to see it is fixed. I will be able to remove my hack soon. |
If you have an ion-input element with type="number". When the model changes to zero, the label does not float up.
I expect the label to float up.
Steps to reproduce:
Calculate
buttonHere is the plunker that demonstrates the issue:
http://plnkr.co/edit/TEWz3FtRTH1lWgXbWHNU?p=preview
Cordova CLI: 6.3.1
Gulp version: CLI version 3.9.1
Gulp local: Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0-beta.37
Ionic App Lib Version: 2.0.0-beta.20
ios-deploy version: 1.8.5
ios-sim version: 3.1.1
OS: Mac OS X El Capitan
Node Version: v5.8.0
Xcode version: Xcode 7.3.1 Build version 7D1014
The text was updated successfully, but these errors were encountered: