fix(typography): Exclude ion-item on a tags selector

[alan-agius4]

Short description of what this resolves:

The fore color of the item is being overwritten when it's applied on an a tag because of the 2 directives (text and item) that are setting the "color".

Changes proposed in this pull request:

• Exclude ion-item on a tag

Ionic Version: 2.x

Fixes: #8293

[alan-agius4]

tried to create a Unit Test, but I am having issues
#8341

[manucorporat]

Regarding this issue. I am not sure this fix is scaling well.
We should also add :not([ion-fab]) for completeness.

This makes me think something is fundamentally wrong when we need a selector like:

a:not([ion-button]):not([ion-item]):not([ion-fab])

Maybe we should remove <a> completly from the Typography directive.

@brandyscarney thoughts?

[brandyscarney]

Hmmm we'll have to discuss this @manucorporat. We could just style an anchor with primary by default but then they would have to change the color via sass, or we could add a unique attribute for anchor tags which could be used for all of our styles.

[alan-agius4]

That's a good idea as well :-)

On Sunday, 2 October 2016, Brandy Carney [email protected] wrote:

Hmmm we'll have to discuss this @manucorporat
https://github.com/manucorporat. We could just style an anchor with
primary by default but then they would have to change the color via sass,
or we could add a unique attribute for anchor tags which could be used for
all of our styles.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#8340 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQv-Wmr-EIjqp-HIKMRnJBvTbEeNFZi6ks5qwBqegaJpZM4KK09K
.

[brandyscarney]

Thanks! I'll add details about this on #8293 in a bit. :)