Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): suffix templates page #8320 #8368

Merged
merged 2 commits into from
Oct 18, 2016

Conversation

ramonornela
Copy link
Contributor

Short description of what this resolves:

Added suffix Page to templates generated by

ionic g page <mypage>

and

ionic g tabs <mypage>

Changes proposed in this pull request:

Ionic Version: 2.0.0-rc.0

Fixes: #8320

@ramonornela
Copy link
Contributor Author

ping @danbucholtz

@danbucholtz
Copy link
Contributor

@ramonornela,

Will validate and merge tonight.

Thanks,
Dan

@danbucholtz
Copy link
Contributor

danbucholtz commented Oct 12, 2016

@mlynch, we were talking about this a bit earlier. Does this match up with what you were imagining?

@ramonornela
Copy link
Contributor Author

Related ionic-team/ionic-app-generators#2

@jgw96 jgw96 merged commit 61620f8 into ionic-team:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants