Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldEnable option in ion-infinite-scroll after upgrade to RC0 #8380

Closed
jafaripur opened this issue Oct 1, 2016 · 5 comments
Closed

shouldEnable option in ion-infinite-scroll after upgrade to RC0 #8380

jafaripur opened this issue Oct 1, 2016 · 5 comments

Comments

@jafaripur
Copy link

Short description of the problem:

When serve the application this error occured and after remove shouldEnable from infinite scroll it's work.

What behavior are you expecting?

Run the application

Steps to reproduce:

  1. Upgrade to RC0
  2. Serve application
<ion-infinite-scroll (ionInfinite)="doInfinite($event)" [shouldEnable]="showingSection != 'list'">
        <ion-infinite-scroll-content loadingText="{{'Loading more data...' | translate}}"></ion-infinite-scroll-content>
</ion-infinite-scroll>
Unhandled Promise rejection:

Template parse errors:
Can't bind to 'shouldEnable' since it isn't a known property of 'ion-infinite-scroll'.
1. If 'ion-infinite-scroll' is an Angular component and it has 'shouldEnable' input, then verify that it is part of this module.
2. If 'ion-infinite-scroll' is a Web Component then add "CUSTOM_ELEMENTS_SCHEMA" to the '@NgModule.schemas' of this component to suppress this message.
 ("h"></ion-icon></button>
    </ion-list>
    <ion-infinite-scroll (ionInfinite)="doInfinite($event)" [ERROR ->][shouldEnable]="showingSection != 'list'">
        <ion-infinite-scroll-content loadingText="{{'Loadi"): StoreIndexPage@39:60

; Zone: <root> ; Task: Promise.then ; Value:
Error: Template parse errors: Can't bind to 'shouldEnable' since it isn't a known property of 'ion-infinite-scroll'. 1. If 'ion-infinite-scroll' is an Angular component and it has 'shouldEnable' input, then verify that it is part of this module. 2. If 'ion-infinite-scroll' is a Web Component then add "CUSTOM_ELEMENTS_SCHEMA" to the '@NgModule.schemas' of this component to suppress this message. ("h"></ion-icon></button> </ion-list> <ion-infinite-scroll (ionInfinite)="doInfinite($event)" [ERROR ->][shouldEnable]="showingSection != 'list'"> <ion-infinite-scroll-content loadingText="{{'Loadi"): StoreIndexPage@39:60

Which Ionic Version? 1.x or 2.x

2.x RC0

@manucorporat
Copy link
Contributor

@jafaripur shouldEnable was never a valid attribute for ion-infinite-scroll. are you sure it made any difference in previously releases?

@jafaripur
Copy link
Author

I'm just upgrade application and try to fix error occurred after upgrade to RC0. shouldEnable metioned in this doc http://ionicframework.com/docs/v2/api/components/infinite-scroll/InfiniteScroll/ and i'm used it with previous version Beta11

@manucorporat
Copy link
Contributor

manucorporat commented Oct 1, 2016

@jafaripur but It was never mentioned in the doc as a Input:
http://ionicframework.com/docs/v2/2.0.0-beta.11/api/components/infinite-scroll/InfiniteScroll/#input-properties

Previously, it just didn't crash. It silently did not work. This is good, the compiler is telling you, that property does not exist. In beta 11 didn't exist either, but there was not compiler to warn you.

@jafaripur
Copy link
Author

Thank you.

@manucorporat
Copy link
Contributor

manucorporat commented Oct 1, 2016

@jafaripur I submitted a PR to support it though: #8385

manucorporat added a commit to manucorporat/ionic that referenced this issue Oct 9, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Oct 12, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants