feat(infinite-scroll): it can be enabled/disabled from a ng input #8385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucorporat
force-pushed
the
infinite-scroll-enable
branch
from
49f4dd3
to
8e2bbba
Compare
brandyscarney
requested changes
Oct 12, 2016
| @@ -212,11 +222,14 @@ export class InfiniteScroll { | |||
| * enabled or not. Setting to `false` will remove scroll event listeners | |||
| * and hide the display. | |||
| */ | |||
| enable(shouldEnable: boolean) { | |||
| setEnable(shouldEnable: boolean) { | |||
There was a problem hiding this comment.
Let's change this back to enable everywhere to match menu: https://github.com/driftyco/ionic/blob/master/src/components/menu/menu.ts#L538
manucorporat
force-pushed
the
infinite-scroll-enable
branch
from
8e2bbba
to
51b2d6e
Compare
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references #8380