fix(datetime): onChange without formControlName sets input-has-value …

[hotforfeature]

Short description of what this resolves:

When using an <ion-datetime> component outside of a form, checkHasValue() is not called during onChange(), which results in the .input-has-value missing from the <ion-item>

Changes proposed in this pull request:

Changes the default onChange() function to match registerOnChange() and invoke this.checkHasValue(val); after setting the value and updating the text.

Ionic Version: 2.0.0-rc.1

[hotforfeature]

@brandyscarney it's been 2 months since this was opened, any update on if this needs changing or discussion to be merged?

[brandyscarney]

@hotforfeature Is there an issue open that discusses this? Or could you provide an e2e test or plunker that demonstrates the issue please? :)

[hotforfeature]

No open issue yet, here's a plunker:
http://plnkr.co/edit/Vf3V3uUYQurd07ZDigAk?p=preview

This issue affects floating labels only, since the label uses the .input-has-value to indicate whether or not it should float. The plunker shows three datetime items. When an <ion-datetime> is outside or inside a form without a form control to call checkHasValue(), the label does not float when a date is selected.

The <ion-datetime> that is inside a form and has a form control has its label float properly.

[hotforfeature]

This is still an issue in 2.0.0-rc.4, I haven't upgraded to 5 to test yet. Any updates @brandyscarney?

[hotforfeature]

@brandyscarney this bug is still present in the 2.0.0 release. I've updated the plunker to demonstrate: http://plnkr.co/edit/dADXF8OTABXI4Beq1QBr?p=preview

[brandyscarney]

@hotforfeature Thanks! Sorry it took so long to get this in and thank you for the plunkers. I released a nightly with it:

npm install --save --save-exact [email protected]