Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(item): improves performance of sliding item #9005

Merged
merged 1 commit into from
Nov 4, 2016

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Nov 3, 2016

Same technique used in this PR: #8986

This PR should improves dramatically the performance in low end devices:

BEFORE:
screen shot 2016-11-03 at 01 00 41

AFTER:
screen shot 2016-11-03 at 09 22 27

Fixes: #

  • Using new NativeRafDebouncer
  • Events are not zone wrapped unless strictly necessary

- Using new NativeRafDebouncer
- Events are not zone wrapped unless strictly necessary
@manucorporat
Copy link
Contributor Author

manucorporat commented Nov 3, 2016

Further information:

The performance profile used CPU throttling to simulate a low end device.
A reduction of ~60% JS execution time each frame!!

BEFORE:
screen shot 2016-11-03 at 09 28 18

AFTER:
screen shot 2016-11-03 at 09 26 23

@manucorporat manucorporat added this to the 2.0.0-rc.3 milestone Nov 3, 2016
@brandyscarney brandyscarney modified the milestone: 2.0.0-rc.3 Nov 4, 2016
@brandyscarney brandyscarney merged commit 759e3ea into ionic-team:master Nov 4, 2016
@brandyscarney
Copy link
Member

LGTM 👍

@brandyscarney brandyscarney added this to the 2.0.0-rc.3 milestone Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants