Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu is still openable if alert is present #9046

Closed
JumBay opened this issue Nov 5, 2016 · 1 comment
Closed

Menu is still openable if alert is present #9046

JumBay opened this issue Nov 5, 2016 · 1 comment
Assignees
Milestone

Comments

@JumBay
Copy link

JumBay commented Nov 5, 2016

Short description of the problem:

If you open an alert and there is a menu on your page, you still can swipe to open/close it while the alert is present.
This is annoying if you have a menu that is disabled on a specific state (ie not logged in) and the user logged out with the menu opened, he won't be able to close it then.

What behavior are you expecting?

Disable the swipe event when an alert is present

Steps to reproduce:

  1. Present an alert on a page with a menu (which has the swipeEnabled config set to true)

onic rc2 - ionic app20161105134131

See the plunkr

Which Ionic Version? 2 rc2

Platform: any

@manucorporat manucorporat self-assigned this Nov 5, 2016
@manucorporat manucorporat added this to the 2.0.0-rc.3 milestone Nov 5, 2016
@manucorporat manucorporat added the v2 label Nov 5, 2016
@manucorporat
Copy link
Contributor

manucorporat commented Nov 5, 2016

@JumBay Nice catch! looks like it is a long standing issue, also affects "swipe to go back". Fortunately it is an easy fix.

Thanks!

manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 15, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 15, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 15, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants