Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to conditionally remove ion-reorder from ion-item #9065

Closed
aperezbaena opened this issue Nov 7, 2016 · 4 comments
Closed

feat: ability to conditionally remove ion-reorder from ion-item #9065

aperezbaena opened this issue Nov 7, 2016 · 4 comments

Comments

@aperezbaena
Copy link

Type: feat

Ionic Version: 2.x

Platform: all

ion-item includes ion-reorder element in the DOM regardless of reorder="true" is set in the list, or even if it's not included in any ion-list or ion-item-group.

Having an option to prevent this item to be present in the DOM would lead to a cleaner and more performing output.

@manucorporat
Copy link
Contributor

Have you noticed any performance problem caused by having ion-reorder in each item?

ion-reorder should be display: none when reorder is disabled, so it should not affect the layout or performance.

@aperezbaena
Copy link
Author

As you say the whole ion-reorder element is hidden with display: none so it has no impact either in the layout or rendering. However all that unused markup must be parsed by the browser and kept in memory.

image

Couldn't measure up yet, and only a few items so far but it could have an impact with many items.

Besides for the sake of a cleaner DOM, what's the point yo have elements you know you're not going to use (ever)?

@manucorporat
Copy link
Contributor

@aperezbaena-csc will be fixed in next release!

@aperezbaena
Copy link
Author

@manucorporat awesome!!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants