Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic2 nav controller bug when used in popover - .push(somePage) does work, .pop() does throws error #9140

Closed
florianbepunkt opened this issue Nov 13, 2016 · 3 comments
Assignees
Milestone

Comments

@florianbepunkt
Copy link

The issue described here still exists: #8218

My system info:

Cordova CLI: 6.4.0 
Ionic Framework Version: 2.0.0-rc.2
Ionic CLI Version: 2.1.7
Ionic App Lib Version: 2.1.4
Ionic App Scripts Version: 0.0.42
ios-deploy version: 1.9.0 
ios-sim version: 5.0.8 
OS: OS X El Capitan
Node Version: v6.8.0
Xcode version: Xcode 8.1 Build version 8B62

If I open a popover on a details page it has options to Edit or Delete the item. When I delete the item, I want to pop the detail page off of the stack. However, this does not work from within the popover.

this.viewCtrl.dismiss().then(() => {
    this.navCtrl.pop();
});

It throws an error message

polyfills.js:3 Unhandled Promise rejection: Cannot read property 'getTransitionName' of null ; Zone: angular ; Task: Promise.then ; Value: TypeError: Cannot read property 'getTransitionName' of null(…) TypeError: Cannot read property 'getTransitionName' of null

But I can use .push() in the same context, for example

this.viewCtrl.dismiss().then(() => {
this.navCtrl.push(somePage);
});

does work.

@manucorporat manucorporat self-assigned this Nov 14, 2016
@claudioscheer
Copy link

System info

Cordova CLI: 6.4.0
Gulp version:  CLI version 1.2.2
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-rc.2
Ionic CLI Version: 2.1.4
Ionic App Lib Version: 2.1.2
Ionic App Scripts Version: 0.0.39
OS:
Node Version: v7.1.0

The same thing is happen to me!

@lightheaded
Copy link

Same thing. It seems to be caused by enteringView and leavingView both being empty here: https://github.com/driftyco/ionic/blob/5ff7072242bb36cf51a0862384be635c04bf1658/src/navigation/nav-controller-base.ts#L429

@manucorporat manucorporat added this to the 2.0.0-rc.4 milestone Nov 27, 2016
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 4, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants