Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal incorrectly hidden under main view on Android #9323

Closed
westonganger opened this issue Nov 24, 2016 · 9 comments
Closed

Modal incorrectly hidden under main view on Android #9323

westonganger opened this issue Nov 24, 2016 · 9 comments
Assignees
Labels
needs: reply the issue needs a response from the user

Comments

@westonganger
Copy link

Ionic version: (check one with "x")
[ ] 1.x
[x] 2.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
On RC3 when opening modal on Android (browser emulation & device) I do not see anything. Its not frozen persay but pressing anything does nothing. It turns out to be a CSS problem in the framework, this is not part of my custom css. Removing this rule correctly shows the modal and it functions as it should.

.md .modal-wrapper, .wp .modal-wrapper{
  opacity: .01; //remove this to correctly show the modal
}

Expected behavior:
Modal should show, not be hidden.

@westonganger
Copy link
Author

This is also a problem with Windows too. IOS works correctly already.

@manucorporat
Copy link
Contributor

manucorporat commented Nov 25, 2016

@westonganger can you provide some code that reproduces the issue?

@westonganger
Copy link
Author

Just create any modal. Test it out in Ionic Lab, you will see IOS works correctly while Android and Windows results in hidden modal.

this.modalCtrl.create(SomePage).present();

@manucorporat manucorporat self-assigned this Nov 26, 2016
@manucorporat
Copy link
Contributor

@jgw96 can you test this? I can't reproduce it

@jgw96
Copy link
Contributor

jgw96 commented Nov 28, 2016

Hello @westonganger , thanks for opening an issue with us! Unfortunately I cannot reproduce this on Android 4.4.4, Android 5.1.1, Android 6.0.1, and Android 7.0. Which device and version of Android are you running into this issue on?

@jgw96 jgw96 added needs: reply the issue needs a response from the user v2 labels Nov 28, 2016
@westonganger
Copy link
Author

It appears my node_modules was out of date and I was running rc2 (possibly even nightly) version.

@westonganger
Copy link
Author

Scratch that its still a problem.

Ionic Lab Android and Windows views shows this problem. Also running on my Android 4.4.4 device showed the issue as well.

Heres a link to the project. https://github.com/westonganger/ionic_2_modal_issues

Run in with ionic lab and press the Add / Remove Players button. You will see its appears to be frozen in Android and Windows only, press the top right of the title bar to press the modal close button (also hidden) and now the app is "unfrozen" until you perform the same action.

You can see the app working correctly by adding this style.

.md .modal-wrapper, .wp .modal-wrapper{
  opacity: 1;
}

@westonganger westonganger reopened this Nov 29, 2016
@manucorporat
Copy link
Contributor

ok, now I can reproduce, you didn't say anything about:

      modalEnter: 'modal-slide-in',
      modalLeave: 'modal-slide-out',

Working in a fix...

@manucorporat
Copy link
Contributor

Fixed!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 9, 2018
@ionitron-bot ionitron-bot bot unassigned jgw96 Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

No branches or pull requests

3 participants