fix(datetime): enable custom day values #9708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exist When the current year does not exist in yearValues, it was disabling months when it shouldn’t - this commit fixes that so all of the months are enabled. Closes #7190
|
@brandyscarney looks good to me! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH - this contains a commit from manu and me
Enables the ability to pass custom day values, fixes a bug when the current year does not exist in yearValues; it was disabling months when it shouldn’t.
Adds a unit test that will break if the default year is set to today’s year and it doesn’t exist in yearValues.
Fixes #7190