Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.6.3 is broken if you don't already have sqlalchemy installed #286

Open
scottbelden opened this issue Jun 3, 2022 · 0 comments
Assignees
Labels

Comments

@scottbelden
Copy link

With a fresh python environment, if you do pip install pydruid and then do python -c "from pydruid.db import connect" you get ModuleNotFoundError: No module named 'sqlalchemy'.

This is because sqlalchemy is not a required dependency (only an extra):

pydruid/setup.py

Lines 7 to 12 in 893506b

extras_require = {
"pandas": ["pandas"],
"async": ["tornado"],
"sqlalchemy": ["sqlalchemy"],
"cli": ["pygments", "prompt_toolkit>=2.0.0", "tabulate"],
}

However, pydruid.db.exceptions does an import of it without checking if it is installed:

from sqlalchemy.exc import CompileError

@betodealmeida betodealmeida self-assigned this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants