Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next milestone: pm:enable should fail by default if hook_requirements() is not met #4754

Closed
codebymikey opened this issue May 10, 2021 · 0 comments · Fixed by #4874
Closed

Next milestone: pm:enable should fail by default if hook_requirements() is not met #4754

codebymikey opened this issue May 10, 2021 · 0 comments · Fixed by #4874
Labels
area-pm
Milestone
drush11

Comments

@codebymikey
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The solution implemented in #4733 currently attempts to maintain backwards compatibility by allowing invalid module installs to pass by default. Ideally, this shouldn't be the case.

Describe the solution you'd like
Switch the default behaviour so that the install fails by default, and a conscious decision must be made to bypass the installation requirements.

This change in behaviour should only be applied in the next major release.

Additional context
Further discussion is available in the original PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pm
Projects
None yet
Milestone
drush11
Development

Successfully merging a pull request may close this issue.

pm:enable should fail by default if hook_requirements() is not met drush-ops/drush
2 participants
@weitzman @codebymikey