Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error Messaging #131

Closed
RyanThomas73 opened this issue Mar 20, 2019 · 2 comments
Closed

Fix Error Messaging #131

RyanThomas73 opened this issue Mar 20, 2019 · 2 comments

Comments

@RyanThomas73
Copy link

Previously, using patch-package v5.1.1, errors applying patches provided detailed messaging in the format:

**ERROR** Failed to apply patch for package <package name>

... DETAILED INFO AND SUGGESTED RESOLUTION ...

When testing using the 6.0.5 version, the only error message displayed (shown) below provides very little information. The error no longer provides the package name and/or patch file path that it was attempting to parse and it does not provide clear instructions on what the problem is.

Error: hunk header integrity check failed
    ... <stack trace> ...
@ds300
Copy link
Owner

ds300 commented Mar 20, 2019

This is great feedback thanks! I'll look into fixing this asap.

@ds300 ds300 closed this as completed in 48c419f Mar 24, 2019
@ds300
Copy link
Owner

ds300 commented Mar 24, 2019

This is fixed now in v6.0.6 🎉

Here's an example error message

**ERROR** Failed to apply patch for package test
This happened because the patch file patches/test+1.2.3.patch could not be parsed.
If you just upgraded patch-package, you can try running:
patch -p1 -i patches/test+1.2.3.patch
npx patch-package test
Otherwise, try manually creating the patch file again.
If the problem persists, please submit a bug report:
https://github.com/ds300/patch-package/issues/new?title=Patch+file+parse+error&body=%3CPlease+attach+the+patch+file+in+question%3E

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants