Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to force error for patch file version mismatch #314

Closed
jraoult opened this issue May 12, 2021 · 3 comments
Closed

Add a way to force error for patch file version mismatch #314

jraoult opened this issue May 12, 2021 · 3 comments

Comments

@jraoult
Copy link

jraoult commented May 12, 2021

While locally the warning for this case is a nice touch, in CI we run an automated dependency management bot. We would love to see patch-package blocking the auto-merge to let us intervene and update the patch/check that everything is right in the same PR instead of coming back later to create a new PR just for the patch update.

Following the existing convention, it could be a command-line argument like --error-on-warning. I realise this might be a little niche but would you consider this?

By the way thanks for this amazing tool, this is so helpful and lovely to use 👍

@alfaproject
Copy link

I don't think this is niche. I just landed on this issue looking for the exact same thing. It's always a waste of CI resources if we want to keep versions matching.

@charkour
Copy link

charkour commented May 9, 2022

This would be a great feature to add! (Replying to bump this thread)

Edit:
Sorry, I realize now that commenting to bump is annoying and not helpful.

@ds300
Copy link
Owner

ds300 commented Oct 25, 2022

Released in 6.5.0

@ds300 ds300 closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants