Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the common function Compare-ResourcePropertyState from SqlServerDsc #47

Closed
johlju opened this issue Jul 12, 2020 · 1 comment
Closed

Move the common function Compare-ResourcePropertyState from SqlServerDsc #47

johlju opened this issue Jul 12, 2020 · 1 comment
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jul 12, 2020

There is a common function Compare-ResourcePropertyState that is used by both ActiveDriectoryDsc and SqlServerDsc. This function introduces a new design pattern how to evaluate properties in both Test and Set.

The module SqlServerDsc has the lates version of this function which have support for CIM instances.

Suggest moving this function over here so that more modules can use this design pattern more easily.
@johlju johlju added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Jul 12, 2020
@johlju johlju mentioned this issue Jul 12, 2020
Merged
8 tasks
@johlju
Copy link
Member Author

johlju commented Jul 22, 2020

This was merged in PR #48.

@johlju johlju closed this as completed Jul 22, 2020
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johlju