Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Bug while popping Appointment Page done as part of HomePage Refactoring in MVVM #206

Open
abhibhaw opened this issue Apr 12, 2021 · 3 comments · Fixed by #205
Open

Navigation Bug while popping Appointment Page done as part of HomePage Refactoring in MVVM #206

abhibhaw opened this issue Apr 12, 2021 · 3 comments · Fixed by #205
Assignees
@SriramPatibanda
Labels
type: bug Something isn't working

Comments

@abhibhaw
Copy link
Member

Describe the bug
On Clicking the Back button on Appointment Page. The home Page is showing an infinite loading screen.

To Reproduce
Steps to reproduce the behavior:
Use HomePageView and AppointmentPageView instead of Homepage and Appointment page

Expected behavior
Should pop the Appointment Page. The home Page should be visible.

BUG DEMO

bug.mp4

Smartphone (Tested on):

  • Device: One Plus 8
  • OS: Android 11.0
  • Version: 4.1

Additional context
Need to re-review #196 & #197 to find the bug.
@abhibhaw
Copy link
Member Author

abhibhaw commented Apr 12, 2021 •
edited
Loading

@haru-02 Try re-reviewing #196

@DesignrKnight DesignrKnight changed the title HomePage Refactoring in MVVM has some navigation issue while popping Appointment Page. Navigation Bug while popping Appointment Page done as part of HomePage Refactoring in MVVM Apr 15, 2021
@DesignrKnight DesignrKnight added the type: bug Something isn't working label Apr 15, 2021
@nayakastha nayakastha mentioned this issue Apr 29, 2021
Merged
@SriramPatibanda SriramPatibanda linked a pull request Apr 29, 2021 that will close this issue
Migrate sem change to Remote Config, Levelling of the repository with the play store version and minor fixes #205
Merged
@SriramPatibanda
Copy link
Member

Issue re-opened as a wrong PR is linked.

@abhibhaw
Copy link
Member Author

Todo: close this after #227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SriramPatibanda SriramPatibanda

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@DesignrKnight @abhibhaw @SriramPatibanda