-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3 migration #167
Comments
It's be awesome if you might start introducing these changes. Furthermore, you'd be a rockstar in my book if you could write some unit-tests for the affected areas. Naturally, I'd provide any support that I could. I'd even mention you in the documentation for helping with the effort. Hello egoboo. |
I believe i have made all the changes necessary to move this project to python 3 (3.6). |
Merged. |
Wondering if possible to migrate to python3 as the dependencies are available for python3 as well. On a 1st trial, besides the oaut2 lib patch (see issue #166), the following patch for httplib is also required:
diff -Naur GDriveFS-0.14.8-old/gdrivefs/gdtool/drive.py GDriveFS-0.14.8/gdrivefs/gdtool/drive.py
--- GDriveFS-0.14.8-old/gdrivefs/gdtool/drive.py 2016-11-10 11:38:48.477494868 -0600
+++ GDriveFS-0.14.8/gdrivefs/gdtool/drive.py 2016-11-10 11:41:13.914160628 -0600
@@ -4,7 +4,7 @@
import random
import json
import time
-import httplib
+import http.client
import ssl
import tempfile
import pprint
@@ -54,7 +54,7 @@
for n in range(0, 5):
try:
return f(*args, **kwargs)
- except (ssl.SSLError, httplib.BadStatusLine) as e:
+ except (ssl.SSLError, http.client.BadStatusLine) as e:
# These happen sporadically. Use backoff.
_logger.exception("There was a transient connection "
"error (%s). Trying again [%s]: %s",
But that's not all. Some python3 libraries have changed substantially, therefore, there errors to be solved like:
So, more fixes are required...
The text was updated successfully, but these errors were encountered: