Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest dstack configuration JSON schema is invalid #1192

Closed
r4victor opened this issue May 3, 2024 · 0 comments · Fixed by #1193
Closed

Latest dstack configuration JSON schema is invalid #1192

r4victor opened this issue May 3, 2024 · 0 comments · Fixed by #1193
Assignees
Labels
bug Something isn't working

Comments

@r4victor
Copy link
Collaborator

r4victor commented May 3, 2024

If I define a .dstack.yaml configuration, I see VSCode complaining about the parts of the JSON schema being invalid:

Screenshot 2024-05-03 at 09 59 43

This bug was introduced when we migrated to pydantic-duality models (#967) because ResourcesSpec reference is hardcoded while it should be ResourcesSpecRequest after introducing pydantic-duality:

ref_template = "#/definitions/ResourcesSpec/definitions/{model}"

  • Fix ResourcesSpec reference.
  • Add tests to validate json schema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant