Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Configuration for master node network selection #1209

Closed
TheBits opened this issue May 13, 2024 · 2 comments · Fixed by #1225
Closed

[Feature]: Configuration for master node network selection #1209

TheBits opened this issue May 13, 2024 · 2 comments · Fixed by #1225
Labels

Comments

@TheBits
Copy link
Contributor

TheBits commented May 13, 2024

Problem

A job running in multimode mode must correctly identify the IP address of the master node. A master node instance can have multiple network addresses, and we must select the desired address to using it.

Solution

I suggest adding the --network flag to dstack pool add-ssh command. Using this option, we can specify which IP-network (and IP-address) to use from those available on the master node.

The master node must store the IP address of the desired network. The workers will receive the address of the master node.

Workaround

Multinode now works because the master node only has one IP address for the internal network.

Would you like to help us implement this feature by sending a PR?

Yes

@peterschmidt85
Copy link
Contributor

Why dstack run? I thought it must be dstack pool add-ssh.

@TheBits
Copy link
Contributor Author

TheBits commented May 14, 2024

Oh, yes, you're right.

@TheBits TheBits linked a pull request May 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants