Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: shim panics when adding SSH fleets without Docker #1834

Open
r4victor opened this issue Oct 15, 2024 · 1 comment
Open

[Bug]: shim panics when adding SSH fleets without Docker #1834

r4victor opened this issue Oct 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@r4victor
Copy link
Collaborator

r4victor commented Oct 15, 2024

Steps to reproduce

  1. Create an ssh fleet on instances without Docker installed.
  2. Fleet hangs in status pending.

Actual behaviour

The shim fails with the panic:

panic: cannot get Docker info

goroutine 1 [running]:
main.getDiskSize()
	/home/runner/work/dstack/dstack/runner/cmd/shim/main.go:280 +0x23d
main.writeHostInfo()
	/home/runner/work/dstack/dstack/runner/cmd/shim/main.go:218 +0xdd
main.main.func1(0xc0000ca2c0?)
	/home/runner/work/dstack/dstack/runner/cmd/shim/main.go:154 +0x533
github.com/urfave/cli/v2.(*Command).Run(0xc0000ca2c0, 0xc0000a3000, {0xc0001375e0, 0x1, 0x1})
	/home/runner/go/pkg/mod/github.com/urfave/cli/[email protected]/command.go:279 +0x9dd
github.com/urfave/cli/v2.(*Command).Run(0xc0000ca580, 0xc0000a2d00, {0xc0000900f0, 0x3, 0x3})
	/home/runner/go/pkg/mod/github.com/urfave/cli/[email protected]/command.go:272 +0xc2e
github.com/urfave/cli/v2.(*App).RunContext(0xc0000d6a00, {0xa3eda8?, 0xdaa120}, {0xc0000900f0, 0x3, 0x3})
	/home/runner/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:337 +0x5db
github.com/urfave/cli/v2.(*App).Run(...)
	/home/runner/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:311
main.main()
	/home/runner/work/dstack/dstack/runner/cmd/shim/main.go:167 +0xbce

I initially though it was related to the AMI I was using (Ubuntu 20.04 with cgroupsv1) but it happened to be caused by a failed Docker install which I missed.

Also, this part of the shim code panics everywhere and drops errors without logging...

Expected behaviour

The shim properly handles Docker missing. Ideally, the error is propagated to the server.

dstack version

master

Server logs

No response

Additional information

No response

@r4victor r4victor added the bug Something isn't working label Oct 15, 2024
@r4victor r4victor mentioned this issue Oct 15, 2024
7 tasks
@r4victor r4victor changed the title [Bug]: SSH fleets do not work on Ubuntu 20.04 [Bug]: shim panics when adding SSH fleets without Docker Oct 15, 2024
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Nov 15, 2024
@r4victor r4victor removed the stale label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant