Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Stat-Analysis to compute the CBS score. #1031

Closed
17 of 21 tasks
dwfncar opened this issue Aug 7, 2018 · 2 comments · Fixed by #1892
Closed
17 of 21 tasks

Enhance Stat-Analysis to compute the CBS score. #1031

dwfncar opened this issue Aug 7, 2018 · 2 comments · Fixed by #1892
Assignees
Labels
priority: blocker Blocker requestor: DTC/AF V&V Air Force Verification and Validation Project required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: new feature Make it do something new
Milestone

Comments

@dwfncar
Copy link
Contributor

dwfncar commented Aug 7, 2018

Describe the New Feature

The AF project needs to generate the CBS score on its GPP verification. This requires adding another method of interpolation (areal). Michelle Harrold has provided some code (from Bob Craig) and helpful references (see attachments).

From Bob:

"All, the attached document describes the CBS verification process , I.7-36 Table F. The verification is done over a 1.5 degree remap of the model using an area averaging technique. The ground truth is the model analysis. I have attached the program we use to average the data. The index based on the CBS score is from UKMO. I attached the program that calculates it along with the configuration files."

I have attached the WMO document with I.7-36 Table F as well as the the areal weighting IDL script (around line 251 is the weighting code) and the CBS score python program. Also, the areal weighting script references a paper, which might have some helpful background:

https://www.wmo.int/pages/prog/www/BAS/documents/AnnexDoc3-3.pdf

The work for this issue may include supporting a new interpolation method, computing the CBS score, and writing its output somewhere. Recommend coordinating with @michelleharrold since she's likely familiar with the details.

Acceptance Testing

List input data types and sources.
Describe tests required for new functionality.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG
  • Select scientist(s) or no scientist required: unknown

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added this to the MET 9.0 milestone May 1, 2019
@lisagoodrich
Copy link
Contributor

If there are problems with these attachments, see original JIRA Location:
https://sdg.rap.ucar.edu/jira/browse/MET-1031?filter=12903

WMO_485_Vol_I.pdf
[area_averaging_grib2_cbs.pro.txt]

cbs_um_index_weights.txt

These files have been changed to txt files so they can be saved in this location.
(https://github.com/NCAR/MET/files/3292081/area_averaging_grib2_cbs.pro.txt)

cbs_scoresheet_test.py.txt

@JohnHalleyGotway JohnHalleyGotway self-assigned this Apr 7, 2021
@JohnHalleyGotway JohnHalleyGotway added priority: blocker Blocker requestor: DTC/AF V&V Air Force Verification and Validation Project type: new feature Make it do something new alert: NEED MORE DEFINITION Not yet actionable, additional definition required labels Apr 7, 2021
@JohnHalleyGotway JohnHalleyGotway changed the title Provide interpolation support for AF project -CBS score Enhance MET to compute the CBS score. Apr 7, 2021
@TaraJensen TaraJensen added the required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project label May 17, 2021
@JohnHalleyGotway JohnHalleyGotway linked a pull request Aug 27, 2021 that will close this issue
12 tasks
@JohnHalleyGotway
Copy link
Collaborator

Note that the changes for this task are included in PR #1892.

@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED MORE DEFINITION Not yet actionable, additional definition required label Aug 30, 2021
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance MET to compute the CBS score. Enhance Stat-Analysis to compute the CBS score. Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: blocker Blocker requestor: DTC/AF V&V Air Force Verification and Validation Project required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: new feature Make it do something new
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants