Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Series-Analysis to compute statistics from the SEEPS STAT line type. #2269

Open
8 of 22 tasks
JohnHalleyGotway opened this issue Sep 22, 2022 · 1 comment
Open
8 of 22 tasks
Assignees
Labels
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Sep 22, 2022

Describe the Enhancement

The SEEPS output from Point-Stat and Grid-Stat is configured by setting the corresponding output_flag.seeps and output_flag.seeps_mpr flags. In Series-Analysis, we'll need to add a setting for output_stats.seeps. This is an array of column names for the SEEPS statistics that should be written to the output.

Recommend supporting all SEEPS output columns:

output_flag = {
   seeps = ["TOTAL", "S12", "S13", "S21", "S23", "S31", "S32", "PF1", "PF2", "PF3", "PV1", "PV2", "PV3", "MEAN_FCST", "MEAN_OBS", "SEEPS" ];
}

But please confirm with @RachelNorth that this is correct.

Note that the column names mentioned above have been modified by #2882. Review those changes and update the description above prior to beginning this work.

Acceptance Testing

List input data types and sources.
Describe tests required for new functionality.

Time Estimate

Estimate the amount of work required here.
Unknown

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

Complete this work prior to the end of the Met Office contract at the end of March 2025.

Funding Source

Prior to starting work, confirm with @j-opatz that sufficient funding remains in this account:
2799991

Define the Metadata

Assignee

Labels

  • Select component(s)
  • Select priority medium-to-high
  • Select requestor(s) UK Met Office

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing requestor: UK Met Office United Kingdom Met Office MET: Grid-to-Grid Verification priority: high High Priority labels Sep 22, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Sep 22, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance Series-Analysis to compute statistics from the SEEPS line type. Enhance Series-Analysis to compute statistics from the SEEPS STAT line type. Sep 22, 2022
@JohnHalleyGotway
Copy link
Collaborator Author

As discussed with @mpm-meto on 9/20/24, reassigning this issue to the beta2 cycle of the MET-12.1.0 release, to be completed between January - March of 2025. Marking this as required for that development release. However, before doing this work, check with @j-opatz to confirm that sufficient funding remains to support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🟢 Ready
Development

No branches or pull requests

4 participants