Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper limit on number of point observation stations passed to tools via Python Embedding in met_point_data structure #2292

Open
22 tasks
j-opatz opened this issue Oct 4, 2022 · 0 comments
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue priority: high High Priority requestor: METplus Team METplus Development Team type: bug Fix something that is not working

Comments

@j-opatz
Copy link
Contributor

j-opatz commented Oct 4, 2022

Describe the Problem

As the title suggests, there's seems to be a limit on the number point observation stations that can be passed via Python Embedding. This specifically impacts those tools that utilize the met_point_data structure, which includes Point2Grid, Plot-Point-Obs, Ensemble-Stat, and Point-Stat.

Both Point-Stat and Plot-Point-Obs have been tested for this issue. In the Python script, memory_holding_buoys_script.py, there's a line being used to control the number of stations passed to the tool executing the Python script:

STATS = STATS[:145]

The array slicing is used to toggle between 145 entries (which is the upper limit) and 146 entries (which causes an error).

When set to 145 entries (or any entry amount less than 145), the following command was run on seneca with a successful completion:

/d1/projects/MET/MET_regression/develop/NB20221004/MET-develop/bin/plot_point_obs 'PYTHON_NUMPY=/d1/personal/jopatz/workbench/WW3/scripts/memory_holding_buoys_script.py /d1/personal/jopatz/workbench/WW3/input/buoy_obs/:2022-07-07:2022-07-08:10T' trial.ps 

When the slice is set to 146 (e.g. STATS = STATS[:146]) or any amount above 145, the same command will experience the following error:

ERROR  : 
ERROR  : CRC_Array::operator[](int) const -> range check error ... index = 145, Nelements = 145, Nalloc = 145
ERROR  : 

It remains to be seen if the limit is somewhere in the point processing MET tools, or if the Python structures used to pass the information to MET have a limitation.

Expected Behavior

The point evaluation tools should run successfully, regardless of how many station's worth of information are passed.

Environment

Describe your runtime environment:
*1. Machine: Seneca
*2. OS: Linux
*3. Nightly build of MET (10/04)

To Reproduce

Describe the steps to reproduce the behavior:
*1. Execute the commands listed above

NOTE: the Python script is what controls the number of buoy files passed to MET. Currently, the slice is 146 (so the call fails).

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@j-opatz j-opatz added type: bug Fix something that is not working alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone priority: high High Priority labels Oct 4, 2022
@j-opatz j-opatz added this to the MET 11.0.0 milestone Oct 4, 2022
@JohnHalleyGotway JohnHalleyGotway added required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project and removed required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels Oct 6, 2022
@j-opatz j-opatz removed the required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue priority: high High Priority requestor: METplus Team METplus Development Team type: bug Fix something that is not working
Projects
None yet
Development

No branches or pull requests

2 participants