Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent wildcard character from being used in output file path #1291

Closed
21 tasks
georgemccabe opened this issue Dec 1, 2021 · 1 comment · Fixed by #1353
Closed
21 tasks

Prevent wildcard character from being used in output file path #1291

georgemccabe opened this issue Dec 1, 2021 · 1 comment · Fixed by #1353
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: code optimization Code optimization issue priority: high High Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

The * wildcard character can be used in filename templates to find all files that match, however this character can end up in output templates. This is not a good character to include in file paths since it is used to designate a wildcard character.

Describe the Enhancement

Replace * with 'all' in output paths

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Dec 1, 2021
@georgemccabe georgemccabe self-assigned this Dec 1, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Dec 1, 2021
@georgemccabe georgemccabe added component: code optimization Code optimization issue priority: high High Priority requestor: NCAR/RAL NCAR Research Applications Laboratory labels Dec 1, 2021
@georgemccabe georgemccabe removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Dec 1, 2021
@georgemccabe
Copy link
Collaborator Author

This should be resolved with PR #1353

@georgemccabe georgemccabe linked a pull request Jan 13, 2022 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: code optimization Code optimization issue priority: high High Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant