Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatAnalysis - Allow processing of time ranges other than daily #1871

Closed
19 of 22 tasks
georgemccabe opened this issue Oct 18, 2022 · 0 comments · Fixed by #1869
Closed
19 of 22 tasks

StatAnalysis - Allow processing of time ranges other than daily #1871

georgemccabe opened this issue Oct 18, 2022 · 0 comments · Fixed by #1869
Assignees
Labels
component: use case wrapper METplus: Configuration priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

Currently StatAnalysis wrapper truncates the INIT/VALID_BEG/END times to only use YYYYMMDD. The hours are subset using the lists in the config file, i.e. FCST_VALID_HOUR, OBS_VALID_HOUR, FCST_INIT_HOUR, OBS_INIT_HOUR. Users may want to run the tool on a more specific time range.

Describe the Enhancement

Enhance the wrapper to use the full time specified with INIT/VALID_BEG/END. To preserve previous behavior, if only YYYYMMDD is specified, then set the time range to include the full day of the end date, e.g. if VALID_END = 20221018, then set valid_end = "20221018_235959"

Time Estimate

~1-2 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

5.0.0

Funding Source

None

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: use case wrapper priority: high High Priority requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project METplus: Configuration labels Oct 18, 2022
@georgemccabe georgemccabe added this to the METplus-5.0.0 milestone Oct 18, 2022
@georgemccabe georgemccabe self-assigned this Oct 18, 2022
@georgemccabe georgemccabe linked a pull request Oct 18, 2022 that will close this issue
14 tasks
@georgemccabe georgemccabe changed the title StatAnalysis - allow processing of time ranges other than daily StatAnalysis - Allow processing of time ranges other than daily Oct 25, 2022
@TaraJensen TaraJensen added the reporting: DTC NOAA R2O NOAA Research to Operations DTC Project label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: use case wrapper METplus: Configuration priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants