Update Truth: For dtcenter/MET#2840

[JohnHalleyGotway]

Describe Expected Changes

PR dtcenter/MET#2840 for issue dtcenter/MET#2833 fixes off-by-one bugs in defining both dimensions of range/azimuth grids. These changes will modify nearly all of the output generated by the TC-RMW and TC-Diag tools. This issue is to inspect the differences caused by this change to the MET develop branch and confirm that they're limited to what's expected.

• Link to relevant issue(s): Bugfix: Fix the TC-Diag and TC-RMW tools to correctly handle the range and azimuth settings in range/azimuth grids  MET#2833
• Link to relevant pull request(s): Bugfix #2833 develop azimuth MET#2840

Define the Metadata

Title

• Define the Title of this issue as Update Truth: For dtcenter/{REPO}#{PR_NUMBER} to indicate the repository and pull request that warranted this issue.

Assignee

Assign this issue to the author of the pull request that warranted this issue. Optionally assign anyone else who should review the differences in the output.

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Projects and Milestone

• Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
• Select Milestone as the next official version or Future Versions

Update Truth Checklist

• Review the GitHub Actions workflow that was triggered by the PR merge
  • If no differences were found, note this in a comment.
  • If all of the differences are expected, note this in a comment.
    Include any details of how the review was performed.
  • If unexpected differences are found, the following instructions can
    help uncover potential explanations. If none of these apply and the
    source of the differences cannot be determined, contact the
    METplus wrappers lead engineer (@georgemccabe) for assistance.
    • Search for other open issues that have the label type: update truth
      applied by clicking on the label on this issue. Coordinate with the
      author of these issues to ensure all diffs are properly reviewed.
    • Check if any additional GitHub Actions testing workflows have been
      triggered since the workflow that corresponds to this issue was run.
      Review the latest run to ensure that there are no diffs that are
      unrelated to this issue.
    • If the incorrect differences are caused by the changes from the
      issue that warranted this issue, consider reverting the PR and
      re-opening the issue.
  • Iterate until one of the above conditions apply.
• Approve the update of the truth data
  • Contact the METplus wrappers lead engineer (@georgemccabe) or
    backup lead (@jprestop) to let them know that the truth data can
    be updated.
• Update the truth data.
  This should be handled by a METplus wrappers engineer.
  See the instructions to update the truth data for more info.
• Close this issue.

[JohnHalleyGotway]

I reviewed the output from this GHA testing workflow run.

The differences are limited to the output from the TC-Diag and TC-RMW tools, which is expected based on this bugfix. @jprestop the develop-ref branch can safely be updated.

Here are the details... differences are flagged in 3 different use case groups:

1. diff_use_cases_met_tool_wrapper_0-29_59-63

• Differences in 3 TC-Diag output files TCDiag/tc_diag/2023/sal032023_gfso_doper_2023062012*

2. diff_use_cases_met_tool_wrapper_30-58

• Differences in 1 TCRMW output file: TCRMW/met_tool_wrapper/TCRMW/tc_rmw_aal142016.nc
• Here's a screen shot of the PRMSL difference field which follows a consistent pattern:

3. diff-use_cases_tc_and_extra_tc_0-2

• Differences in 1 TCRMW output file: tc_and_extra_tc/TCRMW_fcstGFS_fcstOnly_gonzalo/model_applications/tc_and_extra_tc/TCRMW_gonzalo/tc_rmw_gonzal09l.2014101312.nc