Update Truth: For dtcenter/MET#2951

[JohnHalleyGotway]

Describe Expected Changes

This change to the Series-Analysis output NetCDF variable names was unanticipated, but acceptable.

• Link to relevant issue(s): Enhance Series-Analysis to read its own output and incrementally update output statistics over time MET#1371
• Link to relevant pull request(s): Feature #1371 series_analysis MET#2951

Define the Metadata

Title

• Define the Title of this issue as Update Truth: For dtcenter/{REPO}#{PR_NUMBER} to indicate the repository and pull request that warranted this issue.

Assignee

Assign this issue to the author of the pull request that warranted this issue. Optionally assign anyone else who should review the differences in the output.

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Milestone and Projects

• Select Milestone as the next official version if updating truth data for the develop branch OR select next METplus-Wrappers-X.Y.Z bugfix version if updating truth data for a main_vX.Y branch.
• If updating truth data for the develop branch, select the METplus-Wrappers-X.Y.Z Development project OR if updating truth for a main_vX.Y branch, select the Coordinated METplus-X.Y Support project

Update Truth Checklist

• Review the GitHub Actions workflow that was triggered by the PR merge
  • If no differences were found, note this in a comment.
  • If all of the differences are expected, note this in a comment.
    Include any details of how the review was performed.
  • If unexpected differences are found, the following instructions can
    help uncover potential explanations. If none of these apply and the
    source of the differences cannot be determined, contact the
    METplus wrappers lead engineer (@georgemccabe) for assistance.
    • Search for other open issues that have the label type: update truth
      applied by clicking on the label on this issue. Coordinate with the
      author of these issues to ensure all diffs are properly reviewed.
    • Check if any additional GitHub Actions testing workflows have been
      triggered since the workflow that corresponds to this issue was run.
      Review the latest run to ensure that there are no diffs that are
      unrelated to this issue.
    • If the incorrect differences are caused by the changes from the
      issue that warranted this issue, consider reverting the PR and
      re-opening the issue.
  • Iterate until one of the above conditions apply.
• Approve the update of the truth data
  • Contact the METplus wrappers lead engineer (@georgemccabe) or
    backup lead (@jprestop) to let them know that the truth data can
    be updated.
• Update the truth data.
  This should be handled by a METplus wrappers engineer.
  See the instructions to update the truth data
  for more info.
• Close this issue.

[JohnHalleyGotway]

The testing workflow run triggered by merging dtcenter/MET#2951 into develop flagged differences in a one Series-Analysis output file from one use case group (use_cases_s2s_4):

s2s/SeriesAnalysis_fcstCFSv2_obsGHCNCAMS_climoStandardized_MultiStatisticTool/SA_run2/198201to201002_CFSv2_SA_output.nc
s2s/SeriesAnalysis_fcstCFSv2_obsGHCNCAMS_climoStandardized_MultiStatisticTool/SA_run2/198201to201002_CFSv2_SA_truth.nc

The differences are only in the variable names, not the data.
Truth variable names:

	float series_pstd_TOTAL(lat, lon) ;
	float series_pstd_BRIER(lat, lon) ;
	float series_pstd_RELIABILITY(lat, lon) ;
	float series_pstd_BRIERCL(lat, lon) ;
	float series_pstd_BSS(lat, lon) ;

Output variable names:

	float series_pstd_TOTAL_obsleOCDP33(lat, lon) ;
	float series_pstd_BRIER_obsleOCDP33(lat, lon) ;
	float series_pstd_RELIABILITY_obsleOCDP33(lat, lon) ;
	float series_pstd_BRIERCL_obsleOCDP33(lat, lon) ;
	float series_pstd_BSS_obsleOCDP33(lat, lon) ;

And I used ncview to visually validate that the data values remain unchanged.

Here's the reason for the diff.

For MET version 12.0.0-beta5, the Series-Analysis PSTD output variable names DO NOT include the observation threshold, as seen on this line. I'll note however that the threshold is included for other probabilistic line type outputs (like PCT and PJC). Including it in 2 output types but not all 3 is rather inconsistent.

For the updated version of develop, defining all probabilistic output variable names is now handled in a single build_nc_var_name_probabilistic() function. And since that function adds it for all probabilistic line types, we see this difference in the PSTD variable names.

I'll note that we do not necessarily have to include the threshold in the variable name. Series-Analysis can only run on a single series of data and do probabilistic vx with a single set of thresholds. So no single Series-Analysis output file would contain multiple variables with different thresholds.

In general, we do include threshold information, when applicable, for other output types, like continuous, categorical, and partial sums outputs. So including it for probabilistic outputs is consistent.