-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ryu format 3.2 as 0.0 on powerpc64le #47
Comments
If std::fmt is formatting it as 0 as well, I would propose that this is unlikely to be a bug in this crate. Once whatever is broken in std or rustc has been fixed, if ryu is still incorrect after that, please follow up. |
Sure. |
@dtolnay Please reopen this as the nightly |
What was the fix? |
We didn't fix the code, somehow after updating nightly, the bug is fixed, but ryu still format 3.2_f32 as 0.0, but format the f64 correctly. I also discovered a minor bug in std format, f32::NEG_INFINITY is formatted as "inf" instead of "-inf". |
If it randomly goes away without any relevant code changes in std's formatting code, I am still extremely skeptical that it would need a code change in ryu's formatting code as opposed to the bug being elsewhere. |
Yeah, it looks like a bug in generating the assembly in |
In my PR ParkMyCar/compact_str#16 , when formatting 3.2 using ryu (currently disabled due to bug), it gives me 0.0 on target powerpc64le instead of 3.2 (it works on all other target).
P.S. formatting using std on the target gives me 0
The text was updated successfully, but these errors were encountered: