Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No copyright statement in license file #613

Closed
MF1-MS opened this issue Apr 1, 2019 · 3 comments
Closed

No copyright statement in license file #613

MF1-MS opened this issue Apr 1, 2019 · 3 comments

Comments

@MF1-MS
Copy link

MF1-MS commented Apr 1, 2019

The MIT License file omits the copyright notice usually present, and this notice is referred to in the license text itself. This makes it harder to properly acknowledge use of this software.

@dtolnay
Copy link
Owner

dtolnay commented Apr 1, 2019

I am not a lawyer but it is my understanding that the copyright line is not a requirement for properly applying the MIT license. Despite being usually present, it is usually inaccurate and meaningless because contributors retain copyright over code that they contribute. The rust-lang/rust repo also does not use such a copyright line (as an example of a project that real lawyers pay attention to). Some discussion in rust-lang/rust#43498 and rust-lang/rust@2a8807e.

@bossmc
Copy link

bossmc commented Apr 2, 2019

(IANAL either, but I've been looking into my company's use of OSS code recently)

Using https://opensource.org/licenses/MIT as a canonical template, I don't see how the middle clause:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

can be conformed to where there is no copyright notice (the rust codebase has https://github.com/rust-lang/rust/blob/master/COPYRIGHT to provide a copyright statement, even if it's not at the top of the license statement. Contribution licenses are indeed complex - a literal interpretation of copyright law suggests that, unless explicitly licensed, external contributions remain copyright of the author and cannot be used by anyone else. In practice this is never a problem, and contributions are assumed to be provided under the same license as the original product, but that still leaves the issue of who the copyright owners are... Maybe

Copyright @dtolney and external contributors (see )

?

@dtolnay
Copy link
Owner

dtolnay commented Apr 2, 2019

I am comfortable sticking with the current setup until I hear from a lawyer that there is something wrong.

In "copies or substantial portions" of Syn, please include one or both of the LICENSE files as-is depending which license you choose to accept the code under. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants