Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The nodes don't connect to each other as they're told to do #49

Open
castarco opened this issue Jun 3, 2019 · 0 comments
Open

The nodes don't connect to each other as they're told to do #49

castarco opened this issue Jun 3, 2019 · 0 comments
Assignees
Labels
bug Something isn't working simulation Related with the simulations themselves

Comments

@castarco
Copy link

castarco commented Jun 3, 2019

Describe the bug
During each experiment execution, a network topology is defined, and further enforced by telling the nodes via RPC calls to which other nodes they have to connect.

After implementing a mitigation for the bug #48 in the PR #46 , a regression was introduced, making impossible for some nodes to connect as they're told to do.

The problematic behaviour was caused by the fact that two networks were created (one as a workaround for the InstaJustify problem, and another one for the experiment itself), but sharing a subset of nodes. These nodes cached some information about peers and tried to connect on their own without complying with the intended topology.

To Reproduce
Checkout the code from the PR #46, and run an experiment, with high probability it will stall before starting the whole network.

Expected behavior
A clear and concise description of what you expected to happen.

Environment
It doesn't matter.

Additional context
Already fixed in the PR #47 (still to be merged).

@castarco castarco added bug Something isn't working simulation Related with the simulations themselves labels Jun 3, 2019
@castarco castarco self-assigned this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working simulation Related with the simulations themselves
Projects
None yet
Development

No branches or pull requests

1 participant