Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the lint checks in Travis #1054

Open
13 of 15 tasks
cmihai opened this issue May 3, 2019 · 0 comments
Open
13 of 15 tasks

Fix the lint checks in Travis #1054

cmihai opened this issue May 3, 2019 · 0 comments
Assignees
@cornelius
Labels
ci Continuous integration

Comments

@cmihai
Copy link
Member

cmihai commented May 3, 2019 •
edited by cornelius
Loading

Currently, the lint checks in Travis are executed, but don't fail the build. Since nobody really looks at the lint output, it's as if we didn't have a linter at all. The following checks in test/lint/ need to be fixed and re-enabled (or removed):

  • Git subtree checks for src/crypto/ctaes, src/secp256k1, src/univalue and src/leveldb
  • lint-circular-dependencies.sh
  • lint-filenames.sh
  • lint-format-strings.sh
  • lint-include-guards.sh (Fix lint-include-guards.sh issues #1123)
  • lint-includes.sh
  • lint-locale-dependence.sh
  • lint-logs.sh
  • lint-python.sh
  • lint-python-shebang.sh
  • lint-python-utf8-encoding.sh
  • lint-shell-locale.sh
  • lint-shell.sh
  • lint-tests.sh
  • lint-whitespace.sh
@cmihai cmihai added the ci Continuous integration label May 3, 2019
This was referenced May 3, 2019
Merged
Merged
@cornelius cornelius self-assigned this Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cornelius cornelius

Labels
ci Continuous integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cornelius @cmihai