Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Python 3.11 #172

Closed
bdestombe opened this issue Jul 19, 2023 · 6 comments
Closed

Support for Python 3.11 #172

bdestombe opened this issue Jul 19, 2023 · 6 comments

Comments

@bdestombe
Copy link
Collaborator

Could we maybe add it to our tests and allow the test to fail? Just to verify what the issues are that need to be resolved to move forward.
@bdestombe
Copy link
Collaborator Author

There are currently no wheels built for netCDF4 on Python 3.11. The issues on their github site shows it is a mess.

Unidata/netcdf4-python#1204

@BSchilperoort
Copy link
Collaborator

are you sure? I can see the 3.11 wheels on pypi https://pypi.org/project/netCDF4/1.6.4/#files

@BSchilperoort
Copy link
Collaborator

We should remove the netcdf version pinning:

python-dts-calibration/pyproject.toml

Line 65 in f0dad9c

"netCDF4<=1.5.8",

@bdestombe
Copy link
Collaborator Author

I had some troubles with netcdf4 versions later than 1.5.8. So maybe it was me who forgot the comment.

This seems to be related gwmod/nlmod#161

Shall we pin it to a minimum of 1.6.4?

@BSchilperoort
Copy link
Collaborator

Yeah, there were some issues. However I think those have been resolved since. Pinning it to >=1.6.4 is probably best.

@bdestombe bdestombe mentioned this issue Jul 28, 2023
Merged
@bdestombe
Copy link
Collaborator Author

Closed with #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdestombe @BSchilperoort