Refactor actions (remove async)

[dubreuia]

There are currently a lot of issues that might come from the (unintentional) use of async:

• Attempt to modify PSI for non-committed Document Attempt to modify PSI for non-committed Document #109
• Got unexpected exception during formatting PsiJavaFile:Testklasse.java: java.lang.IndexOutOfBoundsException: Wrong offset: 1655. Should be in range: [0, 1623] Got unexpected exception during formatting PsiJavaFile:Testklasse.java: java.lang.IndexOutOfBoundsException: Wrong offset: 1655. Should be in range: [0, 1623] #113
• IntelliJ complains that "Refactorings should not be started inside write action" IntelliJ complains that "Refactorings should not be started inside write action" #203

Right now, we instantiate one com.dubreuia.processors.Processor per action (optimize, reformat, quick fix, etc.), and run them by calling #run, but some processor might not be finished when we run the next one (see com.dubreuia.processors.java.InspectionProcessor#run). By re-reading com.intellij.openapi.application.ModalityState, I realised that #invokeLater is frowned upon.

I'll refactor using the abstraction com.intellij.openapi.command.WriteCommandAction and use #invokeAndWait(Runnable, ModalityState.NON_MODAL) everywhere.

[dubreuia]

I thought about #128: we need to compile all the elements at the same time, after the actions (actions might move the line number, make the compilation correct by removing a bad unused import). There's #90 also that should also trigger after the actions.

So we have:

• Actions
  • General
    • RearrangeCode (move to last)
    • OptimizeImports
    • ReformatAllText
    • -Compile-
  • Java
    • FieldMayBeFinal
    • LocalCanBeFinal
    • MethodMayBeStatic
    • UnqualifiedFieldAccess
    • UnqualifiedMethodAccess
    • UnqualifiedStaticUsage
    • CustomUnqualifiedStaticUsage
    • override (TODO wrong id)
    • ControlFlowStatementWithoutBraces
    • serial (TODO wrong id)
    • UnnecessaryThis
    • FinalPrivateMethod
    • UnnecessaryFinalOnLocalVariableOrParameter
    • Convert2Diamond
    • SuppressionAnnotation
    • UnnecessarySemicolon
    • WeakerAccess
• Build
• Inspect
• Save (if no exceptions)

There is com.dubreuia.core.component.SaveActionManager#beforeAllDocumentsSaving that triggers before the specific document saving. Combined with FileDocumentManager.getInstance().getUnsavedDocuments(); we might be able to pipeline correctly the actions.

[dubreuia]

The actions should be notified (create separate issue) see http://www.jetbrains.org/intellij/sdk/docs/user_interface_components/notifications.html?search=notif#top-level-notifications

[dubreuia]

The multiple spawn of save actions manager is probably a problem too: when com.dubreuia.core.component.java.SaveActionManager starts, it stops com.dubreuia.core.component.SaveActionManager. It it happens at the wrong moment it might stop the first in the middle of an action.

There should be two Component (global and java) and only one SaveActionManager.

[dubreuia]

Released in https://github.com/dubreuia/intellij-plugin-save-actions/releases/tag/v1.3.0