Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gym] Ensure values passed to episode.hist_data are of native types #665

Open
mwulfman opened this issue Nov 23, 2023 · 0 comments
Open
Labels
enhancement New feature or request gym P2 Low priority issue python

Comments

@mwulfman
Copy link
Contributor

In python/gym_jiminy/rllib/gym_jiminy/rllib/callbacks.py, line 45:
episode.hist_data.setdefault(key, []).append(value)

if value is not of native type (i.e. for instance if it is numpy.float or numpy.int), it can create significant bottlenecks resulting in an important slow-down in training.

This is likely caused by Tensorboard.

@mwulfman mwulfman changed the title [gym] Ensure values pass to episode.hist_data are of native types [gym] Ensure values passed to episode.hist_data are of native types Nov 23, 2023
@duburcqa duburcqa added enhancement New feature or request gym python P2 Low priority issue labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gym P2 Low priority issue python
Projects
Status: To do
Development

No branches or pull requests

2 participants