From fd8f7d23b5707f2bfe44da8e638cf6e6b3ae4403 Mon Sep 17 00:00:00 2001
From: Sam Ansmink <samansmink@hotmail.com>
Date: Fri, 6 Oct 2023 13:24:22 +0200
Subject: [PATCH] small cleanup

---
 README.md                              |  2 +-
 src/iceberg_functions/iceberg_scan.cpp | 11 +++--------
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/README.md b/README.md
index c86d121..c88ee49 100644
--- a/README.md
+++ b/README.md
@@ -32,7 +32,7 @@ based on pyspark 3.4, which you can install through pip.
 To build the extension with vcpkg, you can build this extension using:
 
 ```shell
-VCPKG_TOOLCHAIN_PATH='<path_to_your_vcpkg_toolchain>' make
+VCPKG_TOOLCHAIN_PATH='<path_to_your_vcpkg_toolchain_cmake_file>' make
 ```
 
 This will build both the separate loadable extension and a duckdb binary with the extension pre-loaded:
diff --git a/src/iceberg_functions/iceberg_scan.cpp b/src/iceberg_functions/iceberg_scan.cpp
index 0767ff2..9880564 100644
--- a/src/iceberg_functions/iceberg_scan.cpp
+++ b/src/iceberg_functions/iceberg_scan.cpp
@@ -223,29 +223,24 @@ static unique_ptr<TableRef> IcebergScanBindReplace(ClientContext &context, Table
 	}
 }
 
-static unique_ptr<FunctionData> IcebergScanBind(ClientContext &context, TableFunctionBindInput &input,
-                                                vector<LogicalType> &return_types, vector<string> &names) {
-	return nullptr;
-}
-
 TableFunctionSet IcebergFunctions::GetIcebergScanFunction() {
 	TableFunctionSet function_set("iceberg_scan");
 
 	auto fun =
-	    TableFunction({LogicalType::VARCHAR}, nullptr, IcebergScanBind, IcebergScanGlobalTableFunctionState::Init);
+	    TableFunction({LogicalType::VARCHAR}, nullptr, nullptr, IcebergScanGlobalTableFunctionState::Init);
 	fun.bind_replace = IcebergScanBindReplace;
 	fun.named_parameters["allow_moved_paths"] = LogicalType::BOOLEAN;
 	fun.named_parameters["mode"] = LogicalType::VARCHAR;
 	function_set.AddFunction(fun);
 
-	fun = TableFunction({LogicalType::VARCHAR, LogicalType::UBIGINT}, nullptr, IcebergScanBind,
+	fun = TableFunction({LogicalType::VARCHAR, LogicalType::UBIGINT}, nullptr, nullptr,
 	                    IcebergScanGlobalTableFunctionState::Init);
 	fun.bind_replace = IcebergScanBindReplace;
 	fun.named_parameters["allow_moved_paths"] = LogicalType::BOOLEAN;
 	fun.named_parameters["mode"] = LogicalType::VARCHAR;
 	function_set.AddFunction(fun);
 
-	fun = TableFunction({LogicalType::VARCHAR, LogicalType::TIMESTAMP}, nullptr, IcebergScanBind,
+	fun = TableFunction({LogicalType::VARCHAR, LogicalType::TIMESTAMP}, nullptr, nullptr,
 	                    IcebergScanGlobalTableFunctionState::Init);
 	fun.bind_replace = IcebergScanBindReplace;
 	fun.named_parameters["allow_moved_paths"] = LogicalType::BOOLEAN;