Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base config file ./strict.json forms cycle [tsconfig.json] #41

Closed
uPaymeiFixit opened this issue Oct 16, 2024 · 1 comment
Closed

Base config file ./strict.json forms cycle [tsconfig.json] #41

uPaymeiFixit opened this issue Oct 16, 2024 · 1 comment
Labels
bug Something isn't working p2 Priority 2 (Medium)

Comments

@uPaymeiFixit
Copy link
Collaborator

image

Not sure if this is a real issue or not; it hasn’t seemed to cause any problems. You should be able to reproduce it by checking out cc04eadf22fc8b5494e48823ef2530556b34528a and running npm run build:js.

@uPaymeiFixit uPaymeiFixit added bug Something isn't working p2 Priority 2 (Medium) labels Oct 16, 2024
@dudeofawesome
Copy link
Owner

I'm thinking this was caused by a bug in esbuild. I'm going to close this for now, but we can re-open it later if this happens again with esbuild@>=0.24.0.

https://github.com/evanw/esbuild/blob/main/CHANGELOG.md#0240

TypeScript 5.0 introduced multiple inheritance for tsconfig.json files where extends can be an array of file paths. Previously esbuild would incorrectly treat files encountered more than once when processing separate subtrees of the multiple inheritance hierarchy as an inheritance cycle. With this release, tsconfig.json files containing this edge case should work correctly without generating a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p2 Priority 2 (Medium)
Projects
Status: Done
Development

No branches or pull requests

2 participants