Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ctrl+z for job control support #249

Closed
yurenchen000 opened this issue May 23, 2023 · 4 comments
Closed

feat: add ctrl+z for job control support #249

yurenchen000 opened this issue May 23, 2023 · 4 comments

Comments

@yurenchen000
Copy link
Contributor

yurenchen000 commented May 23, 2023

how about add ctrl+z for job control support?

#192 mentioned this featrue.

maybe I can send a PR

@yurenchen000
Copy link
Contributor Author

yurenchen000 commented May 23, 2023

here is the RP
#250

I only tested on ubuntu 22, and it just work.


seems tcell and tview not support ctrl+z for job control (so that almost all app based on them also not suppor it)
I can't live without ctrl+z (I noticed the b to spawn shell, but that not what I want).

here is a wrokaround, I only known It can work on ubuntu (maybe).
//seems a small probability terminal state borken

@lilydjwg
Copy link

I want this too. Sometimes I just think I don't need the shell and not start tmux before running gdu, only to find later that I do want to check some files. Opening another connection works but takes time, and it's one more window to manage.

b works, but it's just not my usual workflow. Exiting current shell is a bit dangerous because I may exit elsewhere accidentally to close the connection and lose my context.

@yurenchen000
Copy link
Contributor Author

yurenchen000 commented May 26, 2023

@lilydjwg
exactly, you speak my heart

so I also thought the b embed shell should use a different PS1 prompt

for important bash session set -o ignoreeof1 maybe useful

Footnotes

  1. https://unix.stackexchange.com/a/512864/116915

@dundee
Copy link
Owner

dundee commented May 31, 2023

#250 merged, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants