Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CLPool Contracts for Velodrome_v2 on Optimism in dex.trades table #6828

Open
IvyLabs-Analytics opened this issue Sep 24, 2024 · 3 comments
Labels
dbt: dex covers the DEX dbt subproject help wanted Extra attention is needed

Comments

@IvyLabs-Analytics
Copy link

IvyLabs-Analytics commented Sep 24, 2024

Description

I noticed that there is no data for Velodrome_v2 CLPools, which are their concentrated liquidity pools (an example: 0x478946bcd4a5a22b316470f5486fafb928c0ba25) on Optimism under dex.trades. Here is a sample dune query: https://dune.com/queries/4098255.

Current behavior

Currently that pool/contract address is missing in the table. Other CLPool contracts are also missing.
The velodrome_v2_optimism.CLPool_evt_Swap and velodrome_v2_optimism.CLFactory_evt_PoolCreated tables are missing here: https://github.com/duneanalytics/spellbook/blob/main/dbt_subprojects/dex/models/trades/optimism/platforms/velodrome_optimism_base_trades.sql

Expected behavior

Should be providing information on the current volumes (amount_usd) or token bought/sold.

Possible solution

Add CLFactory and CLPool to spellbook. The contract is similar to Uniswap V3. For the purposes of tracking Swap events, it’s identical. It’s about a 95% fork. I believe there’s a slightly different abi for slot0, which omits only the protocolFees field. There’s additional functionality for staking in their ve(3,3) gauges, but everything else is identical like their Mints, Burns, Swaps, etc.

@IvyLabs-Analytics IvyLabs-Analytics added the bug Something isn't working label Sep 24, 2024
@IvyLabs-Analytics IvyLabs-Analytics changed the title Missing Contract in dex.trades table Missing Contract for Velodrome_v2 on Optimism in dex.trades table Sep 24, 2024
@IvyLabs-Analytics IvyLabs-Analytics changed the title Missing Contract for Velodrome_v2 on Optimism in dex.trades table Missing CLPool Contracts for Velodrome_v2 on Optimism in dex.trades table Sep 26, 2024
@jeff-dude
Copy link
Member

hi @IvyLabs-Analytics -- thank you for raising. we don't proactively add DEXs on our side v often. i would suggest finding a wizard in the community who is willing to help, if you are not able to add yourself

@IvyLabs-Analytics
Copy link
Author

Hey @jeff-dude, thanks for the info! I’m a bit confused, though, because multiple members of Dune support directed me here for this issue. Is there no one from the Dune team responsible for managing DEX contract integrations for Spellbook?

Also, just to clarify—Velodrome is already in Spellbook. The issue is that their new concentrated liquidity pools aren’t included in the current code. It’s the same structure as Aerodrome CL Pools on Base, which are working well in Spellbook.

@jeff-dude jeff-dude reopened this Oct 3, 2024
@jeff-dude
Copy link
Member

i can leave this open to track addition, but to your question, we as spellbook maintainers don't proactively add all contracts to dex.trades. i'm happy to help get it built once PR is initiated, but we need someone to help take those steps.

@jeff-dude jeff-dude added help wanted Extra attention is needed dbt: dex covers the DEX dbt subproject and removed bug Something isn't working labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt: dex covers the DEX dbt subproject help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants