Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone binaries with Caddy cache-handler #956

Closed
laurent-bientz opened this issue Aug 6, 2024 · 2 comments
Closed

Standalone binaries with Caddy cache-handler #956

laurent-bientz opened this issue Aug 6, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@laurent-bientz
Copy link

Describe you feature request

Hello,

Is your feature request related to a problem? Please describe.

We're using frankenphp standalone binaries with api platform and we want to test the new recommended http cache module instead of Varnish.

It seems that cache module is not packaged in the Caddy web server.

Describe the solution you'd like

  • Include cache-handler in the default caddy instance packaged in the binaries?
  • Generate binaries with/without HTTP Cache?

Describe alternatives you've considered

Create static binary ourselves (or using the shell script) but we don't see any Docker ARG (env variables) to enable Caddy's http cache module.

@laurent-bientz laurent-bientz added the enhancement New feature or request label Aug 6, 2024
@dunglas
Copy link
Owner

dunglas commented Aug 6, 2024

We follow Caddy's (@mholt, @francislavoie) and Souin's (@darkweak) strategy here.
Currently, Caddy doesn't include Souin by default because the lib has many external dependencies.

For this reason, we'll not include this module by default either, until it is bundled in upstream Caddy.

@dunglas dunglas closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2024
@darkweak
Copy link

darkweak commented Aug 6, 2024

@laurent-bientz To explain a bit more, I don't want to include the cache-handler in Caddy directly (even after the storages refactoring that reduces the external dependencies) at the moment (and it will never be IMHO) because the cache-handler API (the exported code) we prefer to keep it as external to be able to release independently from the caddy server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants