New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document point addition internal implementation #703

Open

vlopes11 opened this issue Aug 17, 2022 · 1 comment

Contributor

vlopes11 commented Aug 17, 2022

what are x_3 and y_3?

Originally posted by @moCello in #700 (comment)

vlopes11 mentioned this issue

Refactor Composer into trait #700

Merged

Contributor

ashWhiteHat commented Oct 19, 2023

I think x_3 and x_3 are coordinates of added point.
component_add_point constrains a and b JubjubAffine points addition a + b = c.

a: (x_1, y_1)
b: (x_2, y_2)
c (a + b): (x_3, y_3)

In dusk (zkcrypto) Jubjub implementation, the coordinates are expressed as u (x) and v (y).
We should align document notation with either of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment